Skip to content

[MNT] deduplicating utilities with scikit-base #1929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

[MNT] deduplicating utilities with scikit-base #1929

wants to merge 6 commits into from

Conversation

fkiraly
Copy link
Collaborator

@fkiraly fkiraly commented Jul 25, 2025 •
edited
Loading

Deduplicates utilities that were copy-pasted to avoid a scikit-base dependency early on.

Since the v1 testing framework will require scikit-base, it makes sense to now attempt a deduplication.

Adds scikit-base as a core dependency.

@fkiraly fkiraly added the enhancement New feature or request label Jul 25, 2025
@fkiraly fkiraly added the maintenance Continuous integration, unit testing & package distribution label Jul 25, 2025
@fkiraly fkiraly requested a review from yarnabrina as a code owner July 25, 2025 20:07
@fkiraly fkiraly marked this pull request as draft July 25, 2025 20:07
@fkiraly fkiraly marked this pull request as ready for review August 9, 2025 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benHeid benHeid Awaiting requested review from benHeid benHeid is a code owner

@fnhirwa fnhirwa Awaiting requested review from fnhirwa fnhirwa is a code owner

@jdb78 jdb78 Awaiting requested review from jdb78 jdb78 is a code owner

@yarnabrina yarnabrina Awaiting requested review from yarnabrina yarnabrina is a code owner

Assignees
No one assigned
Labels
enhancement New feature or request maintenance Continuous integration, unit testing & package distribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@fkiraly